[ 
https://issues.apache.org/jira/browse/SSHD-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Goldstein Lyor updated SSHD-442:
--------------------------------
    Attachment: 0042-SSHD-442-Attach-knowledge-whether-a-signature-is-sup.patch

*Note*: I define _BuiltinMacs_ as also implementing _OptionalFeature_ even 
though (for now...) all are supported. This leaves the door open for future 
implementations which might not be automatically supported (and makes the 
mechanism be standard - like the other _BuiltinXXX_ values)

> Attach knowledge whether a signature is supported to the BuiltinSignature(s) 
> enums
> ----------------------------------------------------------------------------------
>
>                 Key: SSHD-442
>                 URL: https://issues.apache.org/jira/browse/SSHD-442
>             Project: MINA SSHD
>          Issue Type: Improvement
>    Affects Versions: 1.0.0
>            Reporter: Goldstein Lyor
>         Attachments: 
> 0042-SSHD-442-Attach-knowledge-whether-a-signature-is-sup.patch
>
>
> Same as for the rest of the built-in factories. *Note:* I am using this fix 
> to also add the following related improvements:
> - Use an _OptionalFeature_ interface that exports the _isSupported_ method
> - Use standard logic for setup of _Mac_(s) as well
> - Add tests to ensure that the names exported via the respective _Constants_ 
> classes cover all available values
> - Add _SshBuilder_ tests to ensure that the default preferences lists cover 
> all available values.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to