Le 31/03/16 23:15, Guillaume Nodet a écrit : > 2016-03-31 15:13 GMT+02:00 Emmanuel Lécharny <[email protected]>: > >> Le 31/03/16 09:15, Guillaume Nodet a écrit : >>> We're still missing a few binding votes .... >> Damn.. Totally missed the last votes :/ >> >> >> I have tested the package, and teh first time I got an error : >> >> Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 5.098 >> sec <<< FAILURE! - in >> >> org.apache.sshd.client.subsystem.sftp.extensions.helpers.CopyDataExtensionImplTest >> testCopyDataExtension[size=8,192, readOffset=4,096, readLength=2,048, >> >> writeOffset=4,096](org.apache.sshd.client.subsystem.sftp.extensions.helpers.CopyDataExtensionImplTest) >> Time elapsed: 5.014 sec <<< ERROR! >> org.apache.sshd.common.SshException: Failed to get operation result >> within specified timeout: 5000 >> at >> >> org.apache.sshd.client.subsystem.sftp.extensions.helpers.CopyDataExtensionImplTest.testCopyDataExtension(CopyDataExtensionImplTest.java:174) >> at >> >> org.apache.sshd.client.subsystem.sftp.extensions.helpers.CopyDataExtensionImplTest.testCopyDataExtension(CopyDataExtensionImplTest.java:135) >> at >> >> org.apache.sshd.client.subsystem.sftp.extensions.helpers.CopyDataExtensionImplTest.testCopyDataExtension(CopyDataExtensionImplTest.java:121) >> >> >> >> Re-running it twice, both were successful. >> > Not sure if this is an environmental problem or not. Lyor, any idea ? > > >> Otherwise, I think there is a missing Copyright for jcraft, which is >> part of the dependencies : >> >> "JZlib 0.0.* were released under the GNU LGPL license. Later, we have >> switched >> over to a BSD-style license. >> >> >> ------------------------------------------------------------------------------ >> Copyright (c) 2000,2001,2002,2003 ymnk, JCraft,Inc. All rights reserved. >> >> Redistribution and use in source and binary forms, with or without >> modification, are permitted provided that the following conditions are met: >> >> 1. Redistributions of source code must retain the above copyright notice, >> this list of conditions and the following disclaimer. >> >> 2. Redistributions in binary form must reproduce the above copyright >> notice, this list of conditions and the following disclaimer in >> the documentation and/or other materials provided with the >> distribution. >> " >> >> >> I know this should have been detected before, and that I (and many >> others) haven't check that for years... Am I wrong ? >> >> > Those dependencies are not distributed in any distribution, so I don't > really see why their copyright / notice should be included.
okie. My +1
