[
https://issues.apache.org/jira/browse/SSHD-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239742#comment-15239742
]
ASF GitHub Bot commented on SSHD-605:
-------------------------------------
GitHub user codeandcodes opened a pull request:
https://github.com/apache/mina-sshd/pull/25
Adding unit tests for RootedFileSystemProvider impl of java.nio.file.…
Per https://issues.apache.org/jira/browse/SSHD-605, these unit tests test
the RootedFileSystemProvider (mirroring the API) to validate that FS actions
taken outside of RootedFileSystem#getRoot() throw an InvalidPathException.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/codeandcodes/mina-sshd
SSHD-605-Add-FileSystemProvider-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mina-sshd/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
----
commit d8e7a2dcb7f394043e4bb46218806127a13d315c
Author: Al Ho <[email protected]>
Date: 2016-04-13T18:14:10Z
Adding unit tests for RootedFileSystemProvider impl of
java.nio.file.spi.FileSystemProvider
----
> VirtualFileSystemFactory allows escaping from root
> --------------------------------------------------
>
> Key: SSHD-605
> URL: https://issues.apache.org/jira/browse/SSHD-605
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 1.0.0
> Environment: Windows, JDK 7
> Reporter: Damien B
> Assignee: Goldstein Lyor
> Labels: security
> Fix For: 1.1.0, 1.3.0
>
>
> Possibly Windows only.
> I start a SFTP server like this:
> sshd = SshServer.setUpDefaultServer();
> [...]
> sshd.setFileSystemFactory(new
> VirtualFileSystemFactory(myRootDir.getCanonicalPath()));
> [...]
> sshd.setSubsystemFactories(Arrays.<NamedFactory<Command>>asList(new
> SftpSubsystemFactory()));
> I connect to the server with FileZilla.
> Upon connexion, the files in myRooDir correctly appear under the server path
> '/'. But if I cd to '/c:/Windows/', the files in C:\Windows\ appear, escaping
> the VFS root.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
