[
https://issues.apache.org/jira/browse/SSHD-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253283#comment-15253283
]
Goldstein Lyor commented on SSHD-663:
-------------------------------------
I am pretty sure you are right - here is a chance to contribute to the project.
Conisder writing a unit test that demonstrates the problem and *fails*. Then
fix the issue and show that the test succeeds. Once done, publish a pull
request.
> Wrong if criteria in org.apache.sshd.common.file.util.ImmutableList.subList()
> -----------------------------------------------------------------------------
>
> Key: SSHD-663
> URL: https://issues.apache.org/jira/browse/SSHD-663
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 1.1.0, 1.1.1, 1.2.0
> Reporter: sirati97
> Priority: Minor
> Labels: easyfix, newbie
> Original Estimate: 2m
> Remaining Estimate: 2m
>
> I do not know whether 1.3.0 is affected.
> in org.apache.sshd.common.file.util.ImmutableList.subList() the if criteria
> is wrong:
> wrong code:
> @Override
> public ImmutableList<T> subList(int fromIndex, int toIndex) {
> if (fromIndex == from && toIndex == to) {
> return this;
> }
> return new ImmutableList<>(data, from + fromIndex, from + toIndex);
> }
> should be:
> @Override
> public ImmutableList<T> subList(int fromIndex, int toIndex) {
> if (fromIndex == 0 && from+toIndex == to) {
> return this;
> }
> return new ImmutableList<>(data, from + fromIndex, from + toIndex);
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
