[ 
https://issues.apache.org/jira/browse/SSHD-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15569674#comment-15569674
 ] 

ASF GitHub Bot commented on SSHD-705:
-------------------------------------

GitHub user lifei opened a pull request:

    https://github.com/apache/mina-sshd/pull/26

    [SSHD-705] fix GSSAPI Auth breaken

    GSSAPI auth is breaken after changing username with getUserName().
    
    
https://github.com/apache/mina-sshd/commit/d19f5eca5714b7055b8655a46aeba0629c9dc05a#diff-6632304d23a69cec2f1da01ee1b4eb8fL127
    
    ```
    -  msgbuf.putString(username);
    + msgbuf.putString(getUserName());
    ```
    
    
https://github.com/apache/mina-sshd/commit/d19f5eca5714b7055b8655a46aeba0629c9dc05a#diff-6632304d23a69cec2f1da01ee1b4eb8fL185
    
    ```
    -  return identity != null ? identity : username;
    + return identity != null ? identity : super.getUserName();
    ```
    
    getUserName() is not equals with username when identity is not null.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lifei/mina-sshd patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/mina-sshd/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #26
    
----
commit 2ca5013dfdf220e589fc29195f5933202d8ece99
Author: 软件工程师李飛 <li...@7v1.net>
Date:   2016-10-12T19:36:35Z

    [SSHD-705] fix GSSAPI Auth breaken
    
    GSSAPI auth is breaken after changing username with getUserName().
    
    
https://github.com/apache/mina-sshd/commit/d19f5eca5714b7055b8655a46aeba0629c9dc05a#diff-6632304d23a69cec2f1da01ee1b4eb8fL127
    
    ```
    -  msgbuf.putString(username);
    + msgbuf.putString(getUserName());
    ```
    
    
https://github.com/apache/mina-sshd/commit/d19f5eca5714b7055b8655a46aeba0629c9dc05a#diff-6632304d23a69cec2f1da01ee1b4eb8fL185
    
    ```
    -  return identity != null ? identity : username;
    + return identity != null ? identity : super.getUserName();
    ```
    
    getUserName() is not equals with username when identity is not null.

----


> GSSAPI auth is breaken after changing username with getUserName()
> -----------------------------------------------------------------
>
>                 Key: SSHD-705
>                 URL: https://issues.apache.org/jira/browse/SSHD-705
>             Project: MINA SSHD
>          Issue Type: Bug
>            Reporter: 李飛
>
> https://github.com/apache/mina-sshd/commit/d19f5eca5714b7055b8655a46aeba0629c9dc05a#diff-6632304d23a69cec2f1da01ee1b4eb8fL127
> -                msgbuf.putString(username);
> +                msgbuf.putString(getUserName());
> https://github.com/apache/mina-sshd/commit/d19f5eca5714b7055b8655a46aeba0629c9dc05a#diff-6632304d23a69cec2f1da01ee1b4eb8fL185
> -        return identity != null ? identity : username;
> +        return identity != null ? identity : super.getUserName();
> getUserName() is not equals with username when identity is not null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to