[
https://issues.apache.org/jira/browse/SSHD-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15777212#comment-15777212
]
ASF GitHub Bot commented on SSHD-724:
-------------------------------------
GitHub user davido opened a pull request:
https://github.com/apache/mina-sshd/pull/28
SSHD-724: SshClient#checkConfig: Do not ovewrite predefined factories
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davido/mina-sshd patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mina-sshd/pull/28.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #28
----
commit 8456cc36874c50016bf60a1a71fbfc0d17509df3
Author: David Ostrovsky <[email protected]>
Date: 2016-12-25T23:24:38Z
SSHD-724: SshClient#checkConfig: Do not ovewrite predefined factories
----
> Fix errors flagged by infer static analyzer
> -------------------------------------------
>
> Key: SSHD-724
> URL: https://issues.apache.org/jira/browse/SSHD-724
> Project: MINA SSHD
> Issue Type: Improvement
> Affects Versions: 1.3.0
> Reporter: David Ostrovsky
> Labels: findbugs, static-analysis
> Fix For: 1.4.0
>
>
> Running infer static analyzer: [1] on latest master produces 113 errors:
> [davido@wizball sshd]$ git describe
> sshd-1.3.0-51-g4f0f4dc
> [davido@wizball sshd]$ uname -a
> Linux wizball 4.8.6-300.fc25.x86_64 #1 SMP Tue Nov 1 12:36:38 UTC 2016 x86_64
> x86_64 x86_64 GNU/Linux
> [davido@wizball sshd]$ java -version
> openjdk version "1.8.0_111"
> OpenJDK Runtime Environment (build 1.8.0_111-b16)
> OpenJDK 64-Bit Server VM (build 25.111-b16, mixed mode)
> [davido@localhost sshd]$ infer -- mvn package
> [...]
> ...too many issues to display (limit=10 exceeded), please see
> /home/davido/projects/sshd/infer-out/bugs.txt or run `inferTraceBugs` for the
> remaining issues.
> Summary of the reports
> NULL_DEREFERENCE: 82
> RESOURCE_LEAK: 31
> The full report can be found here: [2].
> [1] http://fbinfer.com
> [2] http://paste.openstack.org/show/593308
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
