[
https://issues.apache.org/jira/browse/SSHD-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113049#comment-16113049
]
Christian Schneider commented on SSHD-759:
------------------------------------------
Thanks. I have now reworked the karaf ssh code to not use
AbstractGeneratorHostKeyProvider.
See
https://github.com/apache/karaf/commit/fd801e07b5d9034dde4a677a56ab58c6a8ae3307
I create the key on startup if none is already present. We need this feature so
people can start with karaf right away.
I still need a custom class for reading the pem keys as the one in mina sshd
1.6.0 does not work. Guillaume fixed that in a separate issue. So after the
next release I will switch the FileKeyProvider.
> Should not overwrite existing ssh key if the algorithm does not match
> ---------------------------------------------------------------------
>
> Key: SSHD-759
> URL: https://issues.apache.org/jira/browse/SSHD-759
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 1.4.0
> Reporter: Christian Schneider
>
> Currently a key file that does not have the correct algorithm is simply
> deleted.
> I think this is not a good behaviour as the user might have created the key
> explicitly.
> https://github.com/apache/mina-sshd/blob/master/sshd-core/src/main/java/org/apache/sshd/server/keyprovider/AbstractGeneratorHostKeyProvider.java#L238-L244
> I propose we simply throw an exception if the algorithm does not match. Then
> the user can decide if he wants to delete the file or change the algorithm.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
