[ 
https://issues.apache.org/jira/browse/SSHD-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115416#comment-16115416
 ] 

Goldstein Lyor commented on SSHD-761:
-------------------------------------

Looks ok, but I do have several questions:

* Why modify only the local {{ChannelAgentForwarding}} and not the _Unix_ one 
was well
* Why close the agent in {{handleEOF}} (which might not always be called) and 
not in {{close}}

Since you can re-produce it, can you test the change - especially moving the 
{{agent.close}} call to {{closeImmediately0}} - and let me know if it works ?

> The agent forwarding channel is not closed at the end of the session
> --------------------------------------------------------------------
>
>                 Key: SSHD-761
>                 URL: https://issues.apache.org/jira/browse/SSHD-761
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 1.6.0
>            Reporter: Li Fangning
>            Assignee: Goldstein Lyor
>
> Use the Putty client to connect to SSHD and enable Agent Forwarding.
> When the session is closed (with the "exit" command), the putty client does 
> not exit properly because the agent forwarding channel is still open.
> I modified the SSH source code to fix this issue:
> org.apache.sshd.agent.local.ChannelAgentForwarding
> {code:java}
> ......
>     // Overwide org.apache.sshd.common.channel.AbstractChannel#handleEof()
>     @Override
>     public void handleEof() throws IOException {
>         // Close agent forwarding channel
>         if (agent != null) {
>             agent.close();
>         }
>         super.handleEof();
>     }
> }
> {code}
> However, it works
> Please help me confirm whether this change is OK.
> Thanks



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to