[
https://issues.apache.org/jira/browse/SSHD-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199950#comment-16199950
]
ASF GitHub Bot commented on SSHD-776:
-------------------------------------
GitHub user fcav1973 opened a pull request:
https://github.com/apache/mina-sshd/pull/38
[SSHD-776] SSHD local port forwarding close session unexpectedly
This patch contains the following modifications:
1. _AbstractConnectionService.channelWindowAdjust_: we did the same
modifications as for channelEof; checking RFC there is the same level of
ambiguity
2. _Nio2Session.exceptionCaught_: the session should be any closed (the
close method is already resilient to subsequent calls). This was necessay
because we found some messages in write queue afer the exception management.
3. _TcpipServerChannel.close_: this have been changed to let the connector
to close immediatly os gracefully, accordingly to the way the API is called.
Most of the problem we have found where related write messages still pending
during a gracefull close
4. _TcpipServerChannel.handleWriteDataFailure_: this have been necessary
because in case the remote server had closed the connection, some data could be
still waiting in the channel to be written to the outgoing session (even if
channel close have been already sent) that could be already closed. In that
case we should simply have to discard those error.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fcav1973/mina-sshd master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mina-sshd/pull/38.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #38
----
commit 767f2772de040504b53b05e07ef713453a534772
Author: cu0132 <[email protected]>
Date: 2017-10-11T08:10:42Z
https://issues.apache.org/jira/browse/SSHD-776
commit ad67d269d982e0144d085bd08e50cf778cf68e96
Author: cu0132 <[email protected]>
Date: 2017-10-11T08:11:01Z
https://issues.apache.org/jira/browse/SSHD-776
----
> SSHD local port forwarding close session unexpectedly
> -----------------------------------------------------
>
> Key: SSHD-776
> URL: https://issues.apache.org/jira/browse/SSHD-776
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 1.6.0
> Reporter: Fulvio Cavarretta
> Assignee: Goldstein Lyor
> Labels: channel, eof, forwarding, sshd
> Attachments: dmzagent-1.7.0-snapshot.trc,
> dmzagent-WriteAbortException.trc, dmzagent.trc, dmzagent.trc.2,
> sshd.SSHD-776.patch
>
>
> Apache SSHD used in local port forwarding mode.
> A client is connecting to a remote FTP server through Apache SSHD via a
> custom software.
> When a new logical channel inside a single SSHD session get an IO error (e.g.
> the remote destination close the connection suddenly, the whole session is
> shut down causing all other logical channel to be closed (see line 8861of
> attached trace file).
> It seems like the _exceptionCaught_ mathod should not be called in this case
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
