[ 
https://issues.apache.org/jira/browse/DIRMINA-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anton Novikov updated DIRMINA-1079:
-----------------------------------
    Description: 
MINA fails to connect from behind a proxy if endpoint address is not resolved. 
This happens for both HTTP and SOCKS proxy and it seems that the reason for 
this are typos in HttpProxyRequest and SocksProxyRequest. The following changes 
seem to fix the issue:

HttpProxyRequest line 105: replace {{if (!endpointAddress.isUnresolved()) {}} 
with {{if (endpointAddress.isUnresolved()) {}}

SocksProxyRequest line 162: replace {{if (adr != null && !adr.isUnresolved()) 
{}} with {{if (adr != null && adr.isUnresolved()) {}}

Note the negation is gone in both cases

  was:
MINA fails to connect from behind a proxy if endpoint address is not resolved. 
This happens for both HTTP and SOCKS proxy and it seems that the reason for 
this are typos in HttpProxyRequest and SocksProxyRequest. The following changes 
seem to fix the issue:

HttpProxyRequest line 105: replace {{if (!endpointAddress.isUnresolved()) {}} 
with {{if (endpointAddress.isUnresolved()) {}}

SocksProxyRequest line 162: replace {{if (adr != null && !adr.isUnresolved()) 
{}} with {{if (adr != null && adr.isUnresolved()) {}}

Note the negation is gone in both cases. A somewhat similar problem exists with 
SOCKS 4a, where a similar check does not exist, see ProtocolFactory line 198


> MINA fails to connect from behind a proxy if endpoint is not resolved
> ---------------------------------------------------------------------
>
>                 Key: DIRMINA-1079
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-1079
>             Project: MINA
>          Issue Type: Bug
>          Components: Handler
>    Affects Versions: 2.0.16
>            Reporter: Anton Novikov
>            Priority: Major
>
> MINA fails to connect from behind a proxy if endpoint address is not 
> resolved. This happens for both HTTP and SOCKS proxy and it seems that the 
> reason for this are typos in HttpProxyRequest and SocksProxyRequest. The 
> following changes seem to fix the issue:
> HttpProxyRequest line 105: replace {{if (!endpointAddress.isUnresolved()) {}} 
> with {{if (endpointAddress.isUnresolved()) {}}
> SocksProxyRequest line 162: replace {{if (adr != null && !adr.isUnresolved()) 
> {}} with {{if (adr != null && adr.isUnresolved()) {}}
> Note the negation is gone in both cases



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to