Goldstein Lyor commented on SSHD-812:

I agree - the original split was due to the fact that the class was becoming 
too large (too many lines). I tried to have a 2nd split where the 
{{AbstractSftpSubsystemExecutor}} holds stateful data (e.g., handles map, 
executor, session, etc.) and AbstractSftpSubsystemHelper  has not real state. 
Again, it is not a clear cut separation of concerns, but rather more a matter 
of some convenience, although the idea is that in order to implement an 
alternative SFTP subsystem implementation, users can decide at what "level" to 
start the implementation.

> support asynchronous mode for sftp subsystem
> --------------------------------------------
>                 Key: SSHD-812
>                 URL: https://issues.apache.org/jira/browse/SSHD-812
>             Project: MINA SSHD
>          Issue Type: New Feature
>    Affects Versions: 1.7.0
>         Environment: java1.8, linux
>            Reporter: Zhenliang Su
>            Assignee: Goldstein Lyor
>            Priority: Minor
>              Labels: asynchronous, sftp
>         Attachments: Main.java, doRead.png
> I used SSHD as a middleman between client and target sftp server.
> I found that, when filezilla client directly connect to the target sftp 
> server, it transfers fast. When filezilla client connect to the middleman, it 
> transfers slow.
> I analyzed the source code of 
> org.apache.sshd.server.subsystem.sftp.SftpSubsystem#doRead, and I found it 
> behaves like block mode, and client's other SSH_FXP_READ request blocked in 
> the same thread.
> my middleman code:
>  [^Main.java]

This message was sent by Atlassian JIRA

Reply via email to