I don’t think there is any benefit of having it public. It’s only useable with IoBuffer and it’s built in to IoBuffer. Unless someone added more functions to it which aren’t present in IoBuffer such as hex ranges then might as well leave it as is.
On Tue, May 22, 2018 at 10:53 AM Emmanuel Lécharny <[email protected]> wrote: > > > Le 22/05/2018 à 16:04, Jonathan Valliere a écrit : > > Just made the commit so getHexDump() is now perfectly safe without having > > to create a duplicate. > > Thanks for that ! > > One more thing : the IoBufferHexDumper class is package protected, which > is probably a bit limiting. It might be worthful to make it public now > that it is safe. > > wdyt ? > > -- > Emmanuel Lecharny > > Symas.com > directory.apache.org > >
