[ https://issues.apache.org/jira/browse/SSHD-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555357#comment-16555357 ]
Guillaume Nodet commented on SSHD-340: -------------------------------------- I don't think this is a good idea to allow restarting a closed object. One reason is that all the gracefull stuff will not work either because in your commit, the {{CloseFuture}} of the {{AbstractCloseable}} is not reset. And it's not meant to be since the field is final. This also cascades to all inner objects of the client / server. I think it's wiser to just recreate the server. On the thread shutdown, I think we should integrate one commit I did a few weeks ago, mainly https://github.com/gnodet/mina-sshd/commit/58f7198c5a32184d6bff6bc08a4317cc4deb2a67, that may help a bit. > Hanging threads left working when server is shut down > ----------------------------------------------------- > > Key: SSHD-340 > URL: https://issues.apache.org/jira/browse/SSHD-340 > Project: MINA SSHD > Issue Type: Bug > Affects Versions: 0.12.0 > Reporter: Sampo Savolainen > Priority: Major > Original Estimate: 1h > Remaining Estimate: 1h > > SSHD fails to stop properly due to errant threads. I've attached a thread > dump from a point of execution where everything should have been cleaned up. > The hanging threads happen only if the server has accepted connections and > they do not hang forever, they seem to stop themselves after a minute or so. > This might be an executor pool which is not shut down correctly. > Earlier versions (0.8.0 and 0.9.0) did not exhibit this behavior. -- This message was sent by Atlassian JIRA (v7.6.3#76005)