[ 
https://issues.apache.org/jira/browse/SSHD-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16556831#comment-16556831
 ] 

Guillaume Nodet commented on SSHD-835:
--------------------------------------

I haven't implemented the `ClosingExecutor` because there's no good way to 
implement it.  The problem is that in order to cleanly implement the graceful 
close, we need a callback when the close is actually terminated. It is provided 
by the `terminated()` method of the `ThreadPool` class (see 
https://github.com/apache/mina-sshd/blob/master/sshd-core/src/main/java/org/apache/sshd/common/util/threads/ThreadUtils.java#L406-L409)
 which would not work if simply wrapping an existing `ExecutorService`.

> Introduce a Closeable ExecutorService
> -------------------------------------
>
>                 Key: SSHD-835
>                 URL: https://issues.apache.org/jira/browse/SSHD-835
>             Project: MINA SSHD
>          Issue Type: Improvement
>            Reporter: Guillaume Nodet
>            Assignee: Guillaume Nodet
>            Priority: Major
>             Fix For: 2.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to