[
https://issues.apache.org/jira/browse/SSHD-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564284#comment-16564284
]
Bryan Turner commented on SSHD-838:
-----------------------------------
{{LoggingUtils.logExceptionStackTrace}} appears to only be used in [2 places in
the entire
codebase|https://github.com/apache/mina-sshd/search?q=logExceptionStackTrace&unscoped_q=logExceptionStackTrace].
In all the other places where exceptions are logged, they're passed through
directly to SLF4J. Setting aside the _level_ consideration for the moment, how
about removing {{logExceptionStackTrace}} and making the two call sites log the
exception directly? To help move the discussion forward, I've opened [pull
request #65|https://github.com/apache/mina-sshd/pull/65] with a minimal change.
The log levels and messages are unchanged; only how the exceptions are logged
is different.
> Lower the log level in Nio2Acceptor.AcceptCompletionHandler#okToReaccept
> ------------------------------------------------------------------------
>
> Key: SSHD-838
> URL: https://issues.apache.org/jira/browse/SSHD-838
> Project: MINA SSHD
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: jpalacios
> Priority: Minor
> Attachments: sshd-nio-acceptor-logging.patch
>
>
> As discussed in [SSHD-833|https://issues.apache.org/jira/browse/SSHD-833], it
> appears that when a client disconnects before the handshake completes there's
> some pretty loud logging coming from the
> {{Nio2Acceptor.AcceptCompletionHandler#okToReaccept}}.
> The entire message is logged at {{WARN}} level. Also, several lines from the
> stack trace are logged individually at the same level.
> We feel this much logging at {{WARN}} level will be too much noise for system
> administrators who might think there's something wrong with the system. We
> propose:
> # Changing the log level to {{DEBUG}} / {{FINE}}
> # Logging the stacktrace in a single message
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
