[
https://issues.apache.org/jira/browse/SSHD-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576812#comment-16576812
]
ASF GitHub Bot commented on SSHD-840:
-------------------------------------
GitHub user rovarga opened a pull request:
https://github.com/apache/mina-sshd/pull/66
[SSHD-840] Respond to unknown messages with SSH_MSG_UNIMPLEMENTED
Instead of throwing IllegalStateException, implement proper handling
as per https://tools.ietf.org/html/rfc4253#section-11.4.
Signed-off-by: Robert Varga <[email protected]>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rovarga/mina-sshd sshd840
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mina-sshd/pull/66.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #66
----
commit b233ec10208917d6cd476538bba68a3f0b21106a
Author: Robert Varga <robert.varga@...>
Date: 2018-08-10T20:18:27Z
[SSHD-840] Respond to unknown messages with SSH_MSG_UNIMPLEMENTED
Instead of throwing IllegalStateException, implement proper handling
as per https://tools.ietf.org/html/rfc4253#section-11.4.
Signed-off-by: Robert Varga <[email protected]>
----
> Unknown commands cause IllegalStateException instead of being correctly
> handled
> -------------------------------------------------------------------------------
>
> Key: SSHD-840
> URL: https://issues.apache.org/jira/browse/SSHD-840
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 1.6.0, 2.0.0
> Reporter: Robert Varga
> Priority: Major
> Fix For: 2.0.1
>
>
> As [https://github.com/CESNET/libnetconf2/issues/68] shows, MINA SSHD has a
> different behavior than OpenSSH when faced unknowns – in this case coming
> from a buggy server.
> While OpenSSH was able to establish a session, OpenDaylight (using SSHD
> 1.6.0) was not – throwing an IllegalStateException.
> Rather than throwing an exception, send an SSH_MSG_UNIMPLEMENTED as specified
> by [https://tools.ietf.org/html/rfc4253#section-11.4] .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
