lgoldstein commented on a change in pull request #88: Fix download with pattern
issue in rooted filesystem
URL: https://github.com/apache/mina-sshd/pull/88#discussion_r255435196
##########
File path: sshd-scp/src/test/java/org/apache/sshd/client/scp/ScpTest.java
##########
@@ -589,6 +589,53 @@ public void testScpNativeOnDirWithPattern() throws
Exception {
}
}
+ @Test
+ public void testScpVirtualOnDirWithPattern() throws Exception {
+ Path remoteDir = Files.createTempDirectory("remote");
+ sshd.setFileSystemFactory(new VirtualFileSystemFactory(remoteDir));
+
Review comment:
Please use `getTempTargetRelativeFile` (method inherited from
`JUnitTestSupport`) - it makes sure that the file(s) reside under `target`
folder which is cleaned when `mvn clean` is invoked. Your code leaves "orphan"
directories and files in the user's `/tmp` folder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
