lgoldstein commented on issue #93: [SSHD-899] Discard attributes when file 
exist already.
URL: https://github.com/apache/mina-sshd/pull/93#issuecomment-466469033
 
 
   I have made the changes with a a slight variation - see 
https://github.com/apache/mina-sshd/pull/94
   
   * Moved the logic that ignores the attributes to the 
`SftpFileSystemAccessor` - this way, if any user has any issues with this 
behavior they can register their own implementation and change it.
   * I have qualified the test assertions to Unix (on Windows it throws 
`UnsupportedOperationException`).  I will test it on Linux to make sure it 
passes before I merge it in.
       * In this context, please try to run the code on Windows if you can 
before publishing a PR - I usually
      do it myself, but since we are all human I may forget and then we would 
have code that fails on Windows (or Linux...).
   
   Let's close this PR and continue any discussions on the PR I opened

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to