[
https://issues.apache.org/jira/browse/SSHD-899?focusedWorklogId=202733&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-202733
]
ASF GitHub Bot logged work on SSHD-899:
---------------------------------------
Author: ASF GitHub Bot
Created on: 22/Feb/19 17:02
Start Date: 22/Feb/19 17:02
Worklog Time Spent: 10m
Work Description: lgoldstein commented on issue #93: [SSHD-899] Discard
attributes when file exist already.
URL: https://github.com/apache/mina-sshd/pull/93#issuecomment-466469033
I have made the changes with a a slight variation - see
https://github.com/apache/mina-sshd/pull/94
* Moved the logic that ignores the attributes to the
`SftpFileSystemAccessor` - this way, if any user has any issues with this
behavior they can register their own implementation and change it.
* I have qualified the test assertions to Unix (on Windows it throws
`UnsupportedOperationException`). I will test it on Linux to make sure it
passes before I merge it in.
* In this context, please try to run the code on Windows if you can
before publishing a PR - I usually
do it myself, but since we are all human I may forget and then we would
have code that fails on Windows (or Linux...).
Let's close this PR and continue any discussions on the PR I opened
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 202733)
Time Spent: 40m (was: 0.5h)
> Permissions of a file being reset when user sends attributes even during read
> -----------------------------------------------------------------------------
>
> Key: SSHD-899
> URL: https://issues.apache.org/jira/browse/SSHD-899
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 2.2.0
> Reporter: Subramaniajeeva
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> As per [https://tools.ietf.org/html/draft-ietf-secsh-filexfer-13#page-36],
> The 'attrs' field is ignored if an existing file is opened.
> As it is, attributes are being considered even if the file exists. This
> results in resetting permission even when file is opened for read.
>
> This is what I find in debug logs when the issue occurs:
> [id=26] SSH_FXP_OPEN (path=/a/b/c.txt, access=0x81, pflags=0x2,
> attrs=\{permissions=[]})
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
