[
https://issues.apache.org/jira/browse/SSHD-909?focusedWorklogId=216831&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-216831
]
ASF GitHub Bot logged work on SSHD-909:
---------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/19 16:28
Start Date: 21/Mar/19 16:28
Worklog Time Spent: 10m
Work Description: lgoldstein commented on issue #98: [SSHD-909] SFTP
versions extension handler ignores non-numerical ions when resolving the
available ones
URL: https://github.com/apache/mina-sshd/pull/98#issuecomment-475303156
>> I think we should consider backporting a version of this fix to some of
the other branches. I stumbled on this problem in version 1.6.0 that we use and
resorted to creating a custom build for that.
I am sorry, but we cannot afford to backpatch versions due to the
maintenance overhead it would incur - FYI there are slightly more than 1 person
working on this project, and we have our hands full with just the one version
we are maintaining. We are all volunteers maintaining this code on our
(precious few) free time, so we cannot afford to maintain multiple versions.
BTW, I believe that in the version you mention you can extend
`DefaultSftpClient` and override the `negotiateVersion` method. I agree it is
not perfect, but it is a possible workaround.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 216831)
Time Spent: 40m (was: 0.5h)
> Fix SFTP version re-negotiation support
> ---------------------------------------
>
> Key: SSHD-909
> URL: https://issues.apache.org/jira/browse/SSHD-909
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 2.2.0
> Reporter: Goldstein Lyor
> Assignee: Goldstein Lyor
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> According to the
> [standard|[https://tools.ietf.org/html/draft-ietf-secsh-filexfer-11#section-5.5]]
> the versions are *strings* whereas the current code always treats them as
> *integers*.
> {quote}
> string "versions"
> string comma-separated-versions
> 'comma-separated-versions' is a string of comma separated version
> numbers. Defined versions are: "2", "3", "4", "5", "6". Any other
> version advertised by the server must follow the DNS extensibility
> naming convention outlined in [RFC4251].
> For example: "2,3,6,[email protected]".
> {quote}
> Note: the same applies for the client's choice
> {quote}
> string "version-select"
> string version-from-list
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
