Please check make sure all bytes are consumed before releasing the buffers.
On Fri, Apr 5, 2019 at 8:37 AM Emmanuel Lecharny (JIRA) <[email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/DIRMINA-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16810763#comment-16810763 > ] > > Emmanuel Lecharny edited comment on DIRMINA-1103 at 4/5/19 12:36 PM: > --------------------------------------------------------------------- > > Cool ! So I guess we can close this ticket and mark it as resolved? > > Well, I guess we need to call the {{cleanup}} method at the end of > {{inflate}} and {{deflate}}. > > > was (Author: elecharny): > Cool ! So I guess we can close this ticket and mark it as resolved? > > > Avoid sticky byte array buffers in Zlib CompressionFilter > > --------------------------------------------------------- > > > > Key: DIRMINA-1103 > > URL: https://issues.apache.org/jira/browse/DIRMINA-1103 > > Project: MINA > > Issue Type: Improvement > > Affects Versions: 2.0.21 > > Reporter: Jörg Michelberger > > Priority: Major > > > > For each Zlib instance there is a zStream instance which is equipped > with new buffers for each in and out of inflate / deflate. This buffers are > not released after each inflate / deflate. So the last compressed and > uncompressed byte[] and its content for rx and tx is not garbage > collectable on each session. > > It would be great if there was a reset(zStream) method on Zlib which > sets the in and out to static empty byte[] to release these buffers after > usage quite before returning from Zlib.deflate and Zlib.inflate but in the > synchronized block. Something like: > > {{private void resetZStream (zStream) {}} > > {{ zStream.next_in = EMPTY_BYTE_ARRAY;}} > > {{ zStream.next_in_index = 0;}} > > {{ zStream.avail_in = 0;}} > > {{ zStream.next_out = EMPTY_BYTE_ARRAY;}} > > {{ zStream.next_out_index = 0;}} > > {{ zStream.avail_out = 0;}} > > {{}}} > > > > > > -- > This message was sent by Atlassian JIRA > (v7.6.3#76005) >
