Guus der Kinderen created DIRMINA-1109:
------------------------------------------
Summary: Improve PriorityThreadPoolExecutor unit test
Key: DIRMINA-1109
URL: https://issues.apache.org/jira/browse/DIRMINA-1109
Project: MINA
Issue Type: Improvement
Reporter: Guus der Kinderen
Attachments: PriorityThreadPoolExecutorTest.java
The original test was authored by me.
The test should be improved to:
* include a non-single-thread executor thread pool.
* take into account that once a task queue for a session has already been
picked up by a worker thread, any 'prioritized' session tasks will still have
to wait for the work that's already underway to be finished (the original code
does not allow for this, hence it only works with a single thread).
* should take considerably less time to execute (currently runs for ~34
seconds - see DIRMINA-1108)
* be self-validating.
Also, much of the formatting appears to have been lost when my original code
was merged. That could be improved upon too.
As the formatting changes changed ~80% of all lines, I've not bothered to
create a diff of my work. Instead, I'm supplying the java file in its entirety
in an attachment to this JIRA issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)