lgoldstein commented on a change in pull request #104: [SSHD-929] Create
separate listener for remove directory.
URL: https://github.com/apache/mina-sshd/pull/104#discussion_r297318783
##########
File path:
sshd-sftp/src/main/java/org/apache/sshd/server/subsystem/sftp/AbstractSftpSubsystemHelper.java
##########
@@ -1631,8 +1650,8 @@ protected void doRemove(int id, String path,
LinkOption... options) throws IOExc
log.debug("signalRemovalPreConditionFailure(id={})[{}] signal {}
for {}: {}",
id, pathValue, thrown.getClass().getSimpleName(), path,
thrown.getMessage());
}
- listener.removing(session, path);
- listener.removed(session, path, thrown);
+ listener.removingFile(session, path);
+ listener.removedFile(session, path, thrown);
Review comment:
Not sure this is correct - {{signalRemovalPreConditionFailure}} may be
called for both file and directory so by what right do we decide here that it
is a file and not a directory ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
