tomaswolf commented on a change in pull request #105: SSHD-930 Send the client
version string after receiving the version string of the server
URL: https://github.com/apache/mina-sshd/pull/105#discussion_r303488490
##########
File path:
sshd-core/src/main/java/org/apache/sshd/client/session/ClientSessionImpl.java
##########
@@ -90,16 +88,17 @@ public ClientSessionImpl(ClientFactoryManager client,
IoSession ioSession) throw
authFuture.setAuthed(false);
signalSessionCreated(ioSession);
- sendClientIdentification();
- KexExtensionHandler extHandler = getKexExtensionHandler();
- if ((extHandler == null) ||
(!extHandler.isKexExtensionsAvailable(this, AvailabilityPhase.PREKEX))) {
- kexState.set(KexState.INIT);
- sendKexInit();
- } else {
- if (log.isDebugEnabled()) {
- log.debug("<init>({}) delay KEX-INIT until server-side one
received", this);
- }
+ /*
+ * Must be called regardless of whether the client identification
+ * is sent or not immediately in order to allow opening any underlying
+ * proxy protocol - e.g., SOCKS or HTTP CONNECT - otherwise the
server's
+ * identification will never arrive
+ */
+ initializeProxyConnector();
+
+ if (sendImmediateIdentification) {
Review comment:
A tiny bit ugly that `if (sendImmediateIdentification)` is here in
ClientSessionImpl, but the corresponding `if (!sendImmediateIdentification)` is
in the super class AbstractClientSession.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
