[
https://issues.apache.org/jira/browse/SSHD-930?focusedWorklogId=276771&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-276771
]
ASF GitHub Bot logged work on SSHD-930:
---------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/19 15:13
Start Date: 15/Jul/19 15:13
Worklog Time Spent: 10m
Work Description: tomaswolf commented on pull request #105: SSHD-930 Send
the client version string after receiving the version string of the server
URL: https://github.com/apache/mina-sshd/pull/105#discussion_r303484675
##########
File path:
sshd-core/src/main/java/org/apache/sshd/client/session/ClientProxyConnector.java
##########
@@ -31,12 +31,13 @@
@FunctionalInterface
public interface ClientProxyConnector {
/**
- * Invoked just before the client identification is sent so that the
- * proxy can send the meta-data to its peer. Upon successful return
- * the SSH identification line is sent and the protocol proceeds as usual.
+ * Invoked just before the client identification is about to be sent so
that
Review comment:
This comment is not true anymore. It's called just before the SSH protocol
starts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 276771)
Time Spent: 40m (was: 0.5h)
> Send the client version string after receiving the version string of the
> server
> -------------------------------------------------------------------------------
>
> Key: SSHD-930
> URL: https://issues.apache.org/jira/browse/SSHD-930
> Project: MINA SSHD
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Zhenliang Su
> Assignee: Goldstein Lyor
> Priority: Major
> Fix For: 2.3.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The rfc4253 does not indicate whether the ssh client must send its own
> version number right after receiving the version number of the server.
> I have encountered a situation where mina-sshd is used to connect to cisco's
> sshd service, sometimes it can be connected, sometimes not connected.
> Some rules are found by capturing packets. If the client sends its own
> version number after receiving the version number of the server, it can be
> connected. If the client sends its own version number before receiving the
> version number of the server, then it will not be connected.
> I think, a better way is to change the SshClient code to send the version
> number of the client right after receiving the version number of the server.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
