[ https://issues.apache.org/jira/browse/SSHD-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964188#comment-16964188 ]
Lyor Goldstein commented on SSHD-953: ------------------------------------- I have thought about this issue some more and I tend to agree with you that quoted arguments should be stripped before being handed over to the shell for execution - usually quotes are used in case the argument(s) contain spaces, which would cause them to be split incorrectly... > ProcessShellCommandFactory does not parse quoted arguments correctly > -------------------------------------------------------------------- > > Key: SSHD-953 > URL: https://issues.apache.org/jira/browse/SSHD-953 > Project: MINA SSHD > Issue Type: Improvement > Affects Versions: 2.3.0 > Reporter: Niklas Rosenstein > Priority: Minor > > {code:java} > sshServer.setCommandFactory(new ProcessShellCommandFactory(); > {code} > This command factory does not parse quoted arguments correctly. Example: > {code} > "scp -t -r -p '/Volumes/data/input.csv'" > {code} > The last argument is parsed as > {code} > "'/Volumes/git/data/input.csv'" > {code} > when it should be parsed as > {code} > "/Volumes/git/data/input.csv" > {code} > (note the missing single quotes) > The implementation of the parsing uses {{GenericUtils.split()}} rather than a > function that handles quotes correctly. > {code} > ShellFactory factory = new > ProcessShellFactory(GenericUtils.split(command, ' ')); > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org