lgoldstein commented on a change in pull request #116: Add
authorized_keys/verification support for OpenSSH "security key" key types
URL: https://github.com/apache/mina-sshd/pull/116#discussion_r386127914
##########
File path: sshd-core/src/main/java/org/apache/sshd/client/ClientBuilder.java
##########
@@ -79,7 +79,9 @@
BuiltinSignatures.nistp256,
BuiltinSignatures.nistp384,
BuiltinSignatures.nistp521,
+ BuiltinSignatures.sk_ecdsa_sha2_nistp256,
Review comment:
I am not comfortable to adding it as default for the client (for now) -
users who want this should make an "effort" (at least for now).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]