lgoldstein commented on issue #120: Increase log level to error for scp error logs URL: https://github.com/apache/mina-sshd/pull/120#issuecomment-612574982 I am not sure I understand exactly how this would work - however, my main concern is not specifically with this code but rather our overall logging policy. On one hand, we do want to have abnormal situations logged with enough detail to allow debugging, but on the other hand we do not want to "pour" a lot of log messages - especially long stack traces. >> issue the error statement with just the exception's string representation This sounds reasonable, except that unfortunately many exceptions are thrown without any explanatory message. Too often have I seen `IOException: null` - i.e., the code threw `IOException` with no explanation as to what was wrong. Furthermore, I am not sure what `the exception's string representation`means - if it means `toString` then I think it includes the stack trace - which I am not sure is a good idea.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
