[ https://issues.apache.org/jira/browse/SSHD-982?focusedWorklogId=425727&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425727 ]
ASF GitHub Bot logged work on SSHD-982: --------------------------------------- Author: ASF GitHub Bot Created on: 21/Apr/20 14:53 Start Date: 21/Apr/20 14:53 Worklog Time Spent: 10m Work Description: FliegenKLATSCH commented on a change in pull request #124: URL: https://github.com/apache/mina-sshd/pull/124#discussion_r412255847 ########## File path: sshd-core/src/main/java/org/apache/sshd/client/keyverifier/KnownHostsServerKeyVerifier.java ########## @@ -153,35 +153,43 @@ public void setModifiedServerKeyAcceptor(ModifiedServerKeyAcceptor acceptor) { @Override public boolean verifyServerKey(ClientSession clientSession, SocketAddress remoteAddress, PublicKey serverKey) { - Collection<HostEntryPair> knownHosts = getLoadedHostsEntries(); try { if (checkReloadRequired()) { Path file = getPath(); if (exists()) { - knownHosts = reloadKnownHosts(clientSession, file); + updateReloadAttributes(); + keysSupplier = GenericUtils.memoizeLock(getKnownHostSupplier(clientSession, file)); Review comment: Yes, but should not be an issue. If you have an idea how to make it even more robust I am happy to implement it.. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 425727) Time Spent: 40m (was: 0.5h) > Race condition when loading known hosts > --------------------------------------- > > Key: SSHD-982 > URL: https://issues.apache.org/jira/browse/SSHD-982 > Project: MINA SSHD > Issue Type: Bug > Affects Versions: 2.4.0 > Reporter: FliegenKLATSCH > Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > When multiple (client) connections are instantiated in parallel the loaded > known hosts collection might be empty and therefore host key verification > fails. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org