[
https://issues.apache.org/jira/browse/SSHD-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113415#comment-17113415
]
Lyor Goldstein edited comment on SSHD-999 at 5/22/20, 4:36 AM:
---------------------------------------------------------------
{quote}
"Too many authentication failures: 3" where 3 digit gives confusion to user as
he set its value as 2
{quote}
The documentation for this value clearly states
{quote}
Key used to retrieve the value in the configuration properties map of the
maximum number of failed authentication requests before the server closes the
connection.
{quote}
Therefore, the code's interpretation is that you are allowed to make 2 errors
and must succeed on the 3rd. Thus the message is correct. I agree that it can
be interpreted the way you mention, but it can also be interpreted (by others)
the way the I mentioned It is a case of "damned if you do and damned if you
don't" - if I were to adopt your proposed interpretation someone else would
have called it an error as well.
was (Author: lgoldstein):
{quote}
"Too many authentication failures: 3" where 3 digit gives confusion to user as
he set its value as 2
{quote}
The documentation for this value clearly states
{quote}
Key used to retrieve the value in the configuration properties map of the
maximum number of failed authentication requests before the server closes the
connection.
{quote}
Therefore, the code's interpretation is that you are allowed to make 2 errors
and must succeed on the 3rd. Thus the message is correct. I agree that it can
be interpreted the way you mention, but it can also be interpreted (by others)
they way the I mentioned It is a case of "damned if you do and damned if you
don't" - if I were to adopt your proposed interpretation someone else would
have called it an error as well.
> MAX_AUTH_REQUESTS : shows wrong count in message
> ------------------------------------------------
>
> Key: SSHD-999
> URL: https://issues.apache.org/jira/browse/SSHD-999
> Project: MINA SSHD
> Issue Type: Bug
> Reporter: Sandeep
> Priority: Major
> Attachments: image-2020-05-21-22-42-02-187.png
>
>
> If I set above property value to 2 then after 2 failed login it shows
> following message
> "Too many authentication failures: 3" where 3 digit gives confusion to user
> as he set its value as 2
> I checked following code and find that we need to pass user set value to
> message instead of "nbAuthRequests" variable value
>
>
> !image-2020-05-21-22-42-02-187.png|width=1817,height=1022!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
