tomaswolf commented on pull request #156: URL: https://github.com/apache/mina-sshd/pull/156#issuecomment-670007852
I've been wondering about that, too. But I have no use case for calling auth() more than once on a session, and it's unclear to me what that would even mean. Or calling auth() without somehow checking the returned future. But in any case, I don't think there's a gap. (Unless the client code really doesn't check the future from the first auth().) After the first call to auth(), there will always be an AuthFuture. Now that you've made it sticky, it'll only not be reported if client code never checks the future. Perhaps it would have been simpler to resolve the TODO and throw directly. Client code would get the exception, and if it tried an auth() again all the same, so be it. But I'm also fine with your approach. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
