fengjiajie commented on pull request #158: URL: https://github.com/apache/mina-sshd/pull/158#issuecomment-674370332
> What about applying this fix to `DHGEXServer, DHGClient, DHGEXClient` classes ? Please note that some code regarding certificate keys is already in place. I think the fix is not good enough and should be more along the lines of `DHGEXClient`-s handling of certificate keys. > > Also, can we have a unit test in place testing this ? I don't know much about the SSH protocol and I also don't think this is a good approach. I located this code through debugging, and I do not really know the other classes do for(and even the one I modified I'm not quite clearing...), so it may need to be done by someone else or in the future as I learn more about it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
