[
https://issues.apache.org/jira/browse/SSHD-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17180281#comment-17180281
]
Lyor Goldstein commented on SSHD-1060:
--------------------------------------
I think we should make a distinction between storing in fields and storing in
variables within a method scope. The former should be discouraged, but the
latter should be allowed. In other words, I think it should be acceptable to
"freeze" the level value during a method execution and take the risk that
during that method's execution changes in the frozen level enable state will
not be sensed . Ofcourse, this applies only to "short" methods - not ones that
have long lived loops.
> Do not store logger level in fields
> -----------------------------------
>
> Key: SSHD-1060
> URL: https://issues.apache.org/jira/browse/SSHD-1060
> Project: MINA SSHD
> Issue Type: Improvement
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Priority: Major
> Fix For: 2.6.0
>
>
> The log levels can be changed at runtime externally, so the
> {{isDebugEnabled()}} or {{isTraceEnabled()}} should not be stored in fields.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
