[ 
https://issues.apache.org/jira/browse/DIRMINA-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187833#comment-17187833
 ] 

Jonathan Valliere commented on DIRMINA-1130:
--------------------------------------------

Setting those parameters on the Socket Server has been working fine in MINA and 
my other Non-MINA projects.

There has been no disadvantage to setting the value at the Socket Server.  If 
the specific implementation DOES inherit the values then the application 
doesn't need to set it twice.  Anytime we can reduce the instances of 
configuration changes in the kernel the better.

> NIO socket acceptor should not set send buffer size on ServerSocket/Channel.
> ----------------------------------------------------------------------------
>
>                 Key: DIRMINA-1130
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-1130
>             Project: MINA
>          Issue Type: Bug
>          Components: Transport
>    Affects Versions: 2.1.4
>            Reporter: Marcin L
>            Assignee: Jonathan Valliere
>            Priority: Major
>
> NIO socket acceptor should not set *send buffer size* on ServerSocket/Channel.
> Setting *SO_SNDBUF* in NioSocketAcceptor as part of 
> https://issues.apache.org/jira/projects/DIRMINA/issues/DIRMINA-1123 was 
> unecessary.
> *SO_SNDBUF* can be set after socket listen() and connect() system calls. 
> Setting send buffer size will most likely throw Exception inĀ 
> *NioSocketAcceptor* (hotspot JVM).
> See
> sun.nio.ch.ServerSocketChannelImpl#supportedOptions ->
> sun.nio.ch.ServerSocketChannelImpl.DefaultOptionsHolder#defaultOptions
> [http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/tip/src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java|http://example.com]
> [https://github.com/frohoff/jdk8u-jdk/blob/master/src/share/classes/sun/nio/ch/ServerSocketChannelImpl.java|http://example.com]
> Seems like only these options are supported and should be set before socket 
> connection.
> SO_RCVBUF
> SO_REUSEADDR
> SO_REUSEPORT
> IP_TOS



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to