This was my original option, just weary about changing anything with the
public api.

Thanks

On Sun, Sep 13, 2020 at 3:34 AM Jeff MAURY <[email protected]> wrote:

> Add a new method getHexDump with a pretty flag and use the old one to call
>
> with false
>
>
>
> Le dim. 13 sept. 2020 à 01:23, Jonathan Valliere <[email protected]> a
>
> écrit :
>
>
>
> > I'm adding some additional methods to IoBufferHexDumper to produce pretty
>
> > hex dumps for debugging purposes.
>
> >
>
> > Possible options to expose the new methods:
>
> >
>
> >    1. Making IoBufferHexDumper class public instead of package local
>
> >    2. Add another public method to IoBuffer (e.g.
>
> >    IoBuffer#getPrettyHexDump() or #getVerboseHexDump()
>
> >    3. Overload IoBuffer#getHexDump() to include "boolean pretty" to
> enable
>
> >    pretty dumps.
>
> >
>
> > Anyone have any opinions?
>
> >
>
>

Reply via email to