[
https://issues.apache.org/jira/browse/SSHD-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197670#comment-17197670
]
Lyor Goldstein commented on SSHD-1080:
--------------------------------------
{quote}Same signature does not imply same semantics, and a common interface
should only be used when the semantic is the same.
...
The IoSession and IoOutputStream don't deal with SSH packets and should not
implement PacketWriter and the methods should be renamed to write instead of
writePacket (as they really only deal with bytes)...
{quote}
I can live with this distinction - may I suggestwe rename it to
{{writeBuffer(ByteBuffer buffer)}} to indicate it instead of just {{write}}...
and use it for +both+ {{IoSession}} and {{IoOutputStream}} since it seems to be
a common semantic...
> Revisit the PacketWriter interface
> ----------------------------------
>
> Key: SSHD-1080
> URL: https://issues.apache.org/jira/browse/SSHD-1080
> Project: MINA SSHD
> Issue Type: Improvement
> Reporter: Guillaume Nodet
> Priority: Major
>
> The expectations when using {{Session.writePacket}}, {{Channel.writePacket}}
> and {{IoOutputStream.writePacket}} are different, so I don't think it's a
> good idea to use a single interface for those.
> The only real place where it's used is in the {{ThrottlingPacketWriter}}
> which would need to be reworked.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
