[
https://issues.apache.org/jira/browse/SSHD-1080?focusedWorklogId=486841&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-486841
]
ASF GitHub Bot logged work on SSHD-1080:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Sep/20 09:43
Start Date: 21/Sep/20 09:43
Worklog Time Spent: 10m
Work Description: gnodet commented on a change in pull request #169:
URL: https://github.com/apache/mina-sshd/pull/169#discussion_r491911768
##########
File path:
sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java
##########
@@ -254,6 +253,46 @@ protected AbstractSession(
}
}
+ /**
+ * @param len The packet payload size
+ * @param blockSize The cipher block size
+ * @param etmMode Whether using "encrypt-then-MAC" mode
+ * @return The required padding length
+ */
+ protected static int calculatePadLength(int len, int blockSize, boolean
etmMode) {
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 486841)
Time Spent: 1h 20m (was: 1h 10m)
> Revisit the PacketWriter interface
> ----------------------------------
>
> Key: SSHD-1080
> URL: https://issues.apache.org/jira/browse/SSHD-1080
> Project: MINA SSHD
> Issue Type: Improvement
> Reporter: Guillaume Nodet
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The expectations when using {{Session.writePacket}}, {{Channel.writePacket}}
> and {{IoOutputStream.writePacket}} are different, so I don't think it's a
> good idea to use a single interface for those.
> The only real place where it's used is in the {{ThrottlingPacketWriter}}
> which would need to be reworked.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
