[
https://issues.apache.org/jira/browse/SSHD-1125?focusedWorklogId=558866&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-558866
]
ASF GitHub Bot logged work on SSHD-1125:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Feb/21 07:54
Start Date: 27/Feb/21 07:54
Worklog Time Spent: 10m
Work Description: lgoldstein commented on a change in pull request #181:
URL: https://github.com/apache/mina-sshd/pull/181#discussion_r584085459
##########
File path:
sshd-core/src/main/java/org/apache/sshd/server/forward/TcpipServerChannel.java
##########
@@ -215,10 +215,12 @@ protected OpenFuture doInit(Buffer buffer) {
}
if (streaming == Streaming.Async) {
+ int channelId = getId();
out = new BufferedIoOutputStream(
Review comment:
As far as I can tell this code does not affect the issues you mentioned.
IMO it is aligned with the purpose of PR#166 of keeping the in-flight data size
under control.
>> How does this interact with this new mechanism?
I think it "plugs a hole" so to speak since the low-level mechanism is not
aware of the concerns raised in the `BufferIoOutputStream` pending write
requests mechanism.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 558866)
Time Spent: 2h (was: 1h 50m)
> Provide a boundary on BufferedIoOutputStream writing to avoid memory overflow
> -----------------------------------------------------------------------------
>
> Key: SSHD-1125
> URL: https://issues.apache.org/jira/browse/SSHD-1125
> Project: MINA SSHD
> Issue Type: Bug
> Reporter: Lyor Goldstein
> Assignee: Lyor Goldstein
> Priority: Major
> Labels: memory
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Use an upper bound to the data pending in the {{BufferedIoOutputStream}}. The
> max data could be set to the max window size. Blocking until there is enough
> room should allow the client to read the data.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
