[
https://issues.apache.org/jira/browse/SSHD-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303254#comment-17303254
]
Guillaume Nodet edited comment on SSHD-1146 at 3/17/21, 10:02 AM:
------------------------------------------------------------------
The following patch seems to add back the needed imports:
{code}
diff --git a/pom.xml b/pom.xml
index ed5263d5..20258d23 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1421,7 +1421,7 @@
</goals>
<configuration>
<instructions>
-
<Import-Package>org.apache.sshd*;version="[$(version;==;${sshd.osgi.version.clean}),$(version;=+;${sshd.osgi.version.clean}))"</Import-Package>
+
<Import-Package>org.apache.sshd*;version="[$(version;==;${sshd.osgi.version.clean}),$(version;=+;${sshd.osgi.version.clean}))",*</Import-Package>
<Export-Package>*;-noimport:=true</Export-Package>
</instructions>
<noWarningProjectTypes>pom</noWarningProjectTypes>
{code}
This results in the following imports for {{sshd-osgi}}
{code}
Import-Package: javax.crypto,javax.crypto.interfaces,javax.crypto.spec,j
avax.management,javax.security.auth,javax.security.auth.callback,javax.
security.auth.login,net.i2p.crypto.eddsa;resolution:=optional;version="
[0.3,1)",net.i2p.crypto.eddsa.math;resolution:=optional,net.i2p.crypto.
eddsa.spec;resolution:=optional;version="[0.3,1)",org.apache.tomcat.jni
;resolution:=optional,org.bouncycastle.crypto.prng;resolution:=optional
;version="[1.68,2)",org.bouncycastle.openssl;resolution:=optional;versi
on="[1.68,2)",org.bouncycastle.openssl.jcajce;resolution:=optional;vers
ion="[1.68,2)",org.ietf.jgss,org.slf4j;version="[1.7,2)",org.slf4j.even
t;version="[1.7,2)",org.slf4j.helpers;version="[1.7,2)"
{code}
was (Author: gnt):
The following patch seems to add back the needed imports:
{code}
diff --git a/pom.xml b/pom.xml
index ed5263d5..20258d23 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1421,7 +1421,7 @@
</goals>
<configuration>
<instructions>
-
<Import-Package>org.apache.sshd*;version="[$(version;==;${sshd.osgi.version.clean}),$(version;=+;${sshd.osgi.version.clean}))"</Import-Package>
+
<Import-Package>org.apache.sshd*;version="[$(version;==;${sshd.osgi.version.clean}),$(version;=+;${sshd.osgi.version.clean}))",*</Import-Package>
<Export-Package>*;-noimport:=true</Export-Package>
</instructions>
<noWarningProjectTypes>pom</noWarningProjectTypes>
{code}
> Missing Import-Package header in sshd-osgi-2.6.0
> ------------------------------------------------
>
> Key: SSHD-1146
> URL: https://issues.apache.org/jira/browse/SSHD-1146
> Project: MINA SSHD
> Issue Type: Bug
> Reporter: Grzegorz Grzybek
> Priority: Major
> Attachments: manifest-summary-2.5.1.txt, manifest-summary.txt
>
>
> After SSHD-1092, where sshd-core and sshd-common (and other modules) lost
> their OSGi manifests, sshd-core which repackages them, no longer provides any
> {{Import-Package}} headers. Effectively this makes sshd-osgi-2.6.0 unusable
> in OSGi env.
> Remember that e.g., Karaf's {{ssh}} features contains not only sshd-osgi
> bundles (now at version 2.5.1):
> {code:xml}
> <bundle
> start-level="30">mvn:org.apache.sshd/sshd-osgi/${sshd.version}</bundle>
> <bundle start-level="30">mvn:org.apache.sshd/sshd-scp/${sshd.version}</bundle>
> <bundle
> start-level="30">mvn:org.apache.sshd/sshd-sftp/${sshd.version}</bundle>
> {code}
> To better look and compare OSGi headers, please have a look at
> https://ops4j1.jira.com/wiki/spaces/TOOLS/pages/412549134/OSGi+Report+Maven+Plugin
> - you don't have to create special maven module (as we do with Pax
> projects), you can simply invoke:
> {noformat}
> mvn install
> org.ops4j.tools.maven:osgi-report-maven-plugin:0.1.1:manifest-summary
> {noformat}
> inside {{sshd-osgi}} module and you'll get something like
> [^manifest-summary.txt] - it is easy to compare it with similar summary
> created for different version, like [^manifest-summary-2.5.1.txt].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
