gnodet commented on pull request #119: URL: https://github.com/apache/mina-sshd/pull/119#issuecomment-836578989
> This is definitely going in the right direction, but will need more work before it could be incorporated into the main code. > > As for testing: I think testing against a real OpenSSH server would be great. Testing only against an Apache MINA sshd server is better than nothing, but it's inbreeding and actually only shows that both our client and server side can talk to each other. It doesn't show that either implements the SSH protocol correctly; they might both implement their own completely different protocol. But I don't know if the containers used for the CI builds on Travis do actually have OpenSSH, nor do I know what the best way to configure, create and tear down an OpenSSH server during tests would be. We do run tests on Windows; I suspect there at least we might not have an OpenSSH server available. Perhaps @lgoldstein has an idea... Afaik, we don't have any client side test that can use an SSH server other than ours. We could work on that by using `testcontainers`. We're already using it for SFTP to test performance / latency, but it should be easy to setup an OpenSSH server and use it for testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
