[
https://issues.apache.org/jira/browse/SSHD-1017?focusedWorklogId=596854&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596854
]
ASF GitHub Bot logged work on SSHD-1017:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/May/21 19:25
Start Date: 14/May/21 19:25
Worklog Time Spent: 10m
Work Description: tomaswolf commented on a change in pull request #176:
URL: https://github.com/apache/mina-sshd/pull/176#discussion_r632749447
##########
File path: sshd-core/src/main/java/org/apache/sshd/common/BaseBuilder.java
##########
@@ -70,6 +70,7 @@
*/
public static final List<BuiltinCiphers> DEFAULT_CIPHERS_PREFERENCE =
Collections.unmodifiableList(
Arrays.asList(
+ // BuiltinCiphers.cc20p1305_openssh, // TODO: enable by
default when BouncyCastle available
Review comment:
If I understand you right, BC provides this pre-standard ChaCha cipher.
But SecurityUtils gives no clean way to ask for a "ChaCha" cipher from a
particular provider ("BC"). So that's what I was missing.
BuiltinCiphers.cc20p1305_openssh does check whether BC is registered, but in
ChaChaCipher when calling SecurityUtils.getCipher() there's no guarantee you
get the one from BC. Bypass SecurityUtils and ask via
Cipher.getInstance("ChaCha", "BC") directly? Or indeed include your own
implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 596854)
Time Spent: 2h 10m (was: 2h)
> Add support for [email protected]
> ---------------------------------------------
>
> Key: SSHD-1017
> URL: https://issues.apache.org/jira/browse/SSHD-1017
> Project: MINA SSHD
> Issue Type: New Feature
> Reporter: Matt Sicker
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> See [protocol
> details|https://github.com/openbsd/src/blob/master/usr.bin/ssh/PROTOCOL.chacha20poly1305].
> * [RFC 7539|https://tools.ietf.org/html/rfc7539] describes the
> ChaCha20-Poly1305 algorithm.
> * [Dropbear
> implementation|https://github.com/mkj/dropbear/blob/master/chachapoly.c]
> * [OpenSSH
> implementation|https://github.com/openbsd/src/blob/master/usr.bin/ssh/cipher-chachapoly-libcrypto.c]
> The cipher is provided by Bouncycastle.
> As a bonus, this could potentially be adapted to propose an equivalent
> AES/GCM cipher encoding to how OpenSSH implements this ChaCha20-Poly1305
> cipher.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
