alex-sherwin commented on a change in pull request #196:
URL: https://github.com/apache/mina-sshd/pull/196#discussion_r632983368
##########
File path:
sshd-common/src/main/java/org/apache/sshd/client/config/hosts/HostConfigEntry.java
##########
@@ -1087,6 +1087,7 @@ public static void writeHostConfigEntries(
*/
public static List<String> parseConfigValue(String value) {
String s = GenericUtils.replaceWhitespaceAndTrim(value);
+ s = GenericUtils.collapseSpaces(s);
Review comment:
In searching the `ssh_config` man page for "multiple" and "Multiple"
there's quite a few directives that support multiple values, but how they are
specified is all over the place. Some are CSV's, some require repeating the
directive, some say it supports multiple values but fails to specify how to do
so.
`Include`, for example, contains path-like values and can support multiple
values, but it fails to say how to accomplish this (I'm going to assume
multiple `Include` directives, but, it's not explicitly stated like
`IdentityFile`)
So it is probably prudent to make this fix in the context of `Host` only to
avoid any possible conflict with any other directive-specific encoding
peculiarities
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
