[
https://issues.apache.org/jira/browse/SSHD-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17348222#comment-17348222
]
James Nord commented on SSHD-1105:
----------------------------------
Is the "affects version" correct here (2.5.1) I have a test that works with
2.5.1, fails with 2.6.0 and passes with the staged 2.7.0.
the referenced eclipse bug is pointing to 2.6.0 and I could not see a change
that would make this break in 2.5.1 vs 2.5.0 (most likely cause of regression
to me was the change for SSHD-1104?
> Use all possible signatures for a public key type in public key authentication
> ------------------------------------------------------------------------------
>
> Key: SSHD-1105
> URL: https://issues.apache.org/jira/browse/SSHD-1105
> Project: MINA SSHD
> Issue Type: Improvement
> Affects Versions: 2.5.1
> Reporter: Lyor Goldstein
> Assignee: Thomas Wolf
> Priority: Minor
> Fix For: 2.7.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The current code iterates over the keys the user provided and then attempts
> to find a +single+ matching signature factory. However, for some key types
> (e.g., RSA) there is more than one possible signature - e.g., {{ssh-rsa,
> rsa-sha2-256, rsa-sha2-512}}. The code should try +all+ matching signature
> factories in the same +order+ as the user defined them.
> {code:java|title=Pseudo code}
> for (KeyPair kp : userKeys) {
> Collection<String> aliases = KeyUtils.getAllKeyTypeAliases(kp);
> for (SignatureFactory factory : userSignatures) {
> // NOTE: need to check how not to confuse ...-cert@openssh,com..
> key type aliases
> if (aliases.contains(factory.getName()) {
> tryPublicKeyAuth(factory, kp);
> }
> }
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
