smilesometimes edited a comment on pull request #195:
URL: https://github.com/apache/mina-sshd/pull/195#issuecomment-850988381


   HAHHA, I  find this commit , this is a bug .   
   
   At begining  i was wondering  why  the  method of getting keyAlg    in    
org.apache.sshd.client.kex.DHGEXClient#next   and   
org.apache.sshd.client.kex.DHGClient#next was differrent? 
   
   Because the  method KeyUtils.getKeyType(serverKey)  called in DHGEXClient ;  
    when serverKey is "rsa-sha2-256" and  "rsa-sha2-512"  only return "ssh-rsa" 
, this lead to  a  error called  "KeyExchange signature verification failed for 
key type= ssh-rsa". The usage of  DHGClient is right.
   
   I use this way  to bypass this bug let the "ecdh -group " configed before 
the  "diffie-hellman-group", so the DHGClient , not the DHGEXClient , can be 
userd for kex.
   
   `
   KexAlgorithms = 
**ecdh-sha2-nistp256,ecdh-sha2-nistp384,ecdh-sha2-nistp521**,diffie-hellman-group-exchange-sha256,diffie-hellman-group14-sha1,diffie-hellman-group1-sha1.
 `
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to