[ 
https://issues.apache.org/jira/browse/SSHD-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Wolf resolved SSHD-1191.
-------------------------------
    Fix Version/s: 2.7.1
       Resolution: Fixed

The _real_ question here besides (1) and (2) mentioned in the original report is

0. Why does this test re-key at all when chacha20-poly1305 is used? It 
shouldn't.

That is fixed by [commit 
1c5987d4|https://github.com/apache/mina-sshd/commit/1c5987d4]. 
chacha20-poly1305 has a block size of 8, and {{AbstractSession}} computed that 
a re-key was needed every 64k blocks, i.e., every 512kB of data. That is of 
course far too low.

Commit 1c5987d4 fixes this test. Problems (1) and (2) may still exist, but if 
so, they are unrelated to chacha20-poly1305. I'll keep digging and may create a 
new bug if needed.

> SftpTransferTest sometimes hangs (failure during rekeying)
> ----------------------------------------------------------
>
>                 Key: SSHD-1191
>                 URL: https://issues.apache.org/jira/browse/SSHD-1191
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Thomas Wolf
>            Priority: Major
>              Labels: test-stability
>             Fix For: 2.7.1
>
>         Attachments: sftptest_debug_log.txt, sftptest_hang.txt, 
> sftptest_hang_nio_log.txt, sftptest_hang_nio_stack.txt
>
>
> Mentioned in [PR 176|https://github.com/apache/mina-sshd/pull/176]: 
> {{SftpTransferTest}} hangs sometimes.
> Observed this myself; got the hang once with NIO and once with mina.
> Attached is a jstack dump taking during the hang (from the mina run).
> Apache MINA sshd master; OS X 10.14.6, Java 1.8: Oracle Hotspot jdk1.8.0_191.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to