lgoldstein commented on a change in pull request #201: URL: https://github.com/apache/mina-sshd/pull/201#discussion_r668995415
########## File path: sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java ########## @@ -109,6 +109,16 @@ */ public static final String SESSION = "org.apache.sshd.session"; + /** + * A last-resort timeout for waiting after having received a KEX_INIT message from the peer until we have prepared + * our own KEX proposal. This timeout should actually never be hit unless there is a serious deadlock somewhere and + * the session is never closed. + * + * @see <a href="https://issues.apache.org/jira/browse/SSHD-1197">SSHD-1197</a> + * @see #doKexNegotiation() + */ + private static final Duration KEX_PROPOSAL_SETUP_TIMEOUT = Duration.ofSeconds(42); Review comment: Please use a `CoreModuleProperties#KEX_PROPOSAL_SETUP_TIMEOUT` as initially suggested so that users can decide to shorten/lengthen this value instead of it being hardcoded -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org