Grzegorz Grzybek created DIRMINA-1148:
-----------------------------------------

             Summary: NPE in Socks4LogicHandler
                 Key: DIRMINA-1148
                 URL: https://issues.apache.org/jira/browse/DIRMINA-1148
             Project: MINA
          Issue Type: Bug
    Affects Versions: 2.1.4
            Reporter: Grzegorz Grzybek


{{SOCKS4}} 0x01 packet (establish a TCP/IP stream connection) may contain 
{{ID}} field to send variable-length, null-terminated user ID. However the code 
in {{org.apache.mina.proxy.handlers.socks.Socks4LogicHandler#writeRequest}} 
simply contains:
{code:java}
byte[] userID = request.getUserName().getBytes("ASCII");
{code}

leading to NPE, when the user ID is not set. For example camel-quickfix uses 
mina through quickfix-j library and username is optional.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to