[
https://issues.apache.org/jira/browse/SSHD-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Wolf resolved SSHD-1218.
-------------------------------
Fix Version/s: 2.7.1
Resolution: Fixed
Fixed by
* [commit
12e0b3a6|https://github.com/apache/mina-sshd/commit/12e0b3a6ce441827fdd27f9010f9b19853901744]
* [commit
fc03c20c|https://github.com/apache/mina-sshd/commit/fc03c20c28da5833b8d46d9680a5da57de61dfae]
* [commit
14b4ec07|https://github.com/apache/mina-sshd/commit/14b4ec07e2bfa7fccc6a053846b0bc4cd5d0fddf]
Order of keys tried unchanged.
> Pubkey auth: keys from ssh-agent are used even if
> HostConfigEntry.isIdentitiesOnly() is true
> --------------------------------------------------------------------------------------------
>
> Key: SSHD-1218
> URL: https://issues.apache.org/jira/browse/SSHD-1218
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 2.7.0
> Reporter: Thomas Wolf
> Assignee: Thomas Wolf
> Priority: Major
> Fix For: 2.7.1
>
>
> {{UserAuthPublicKeyIterator}} unconditionally includes keys from the SSH
> agent if there is an {{SshAgentFactory}}. This should be done only if
> {{!HostConfigEntry.isIdentitiesOnly()}}.
> Also, there is a completely superfluous requirement that the SshAgentFactory
> return a non-null {{SshAgent}} in that iterator.
> {{UserAuthPublicKeyIterator.initializeAgentIdentities()}} could just return
> {{null}} in that case.
> Furthermore it would be useful if the session was passed through to
> {{SshAgentFactory.createAgent()}}.
> Finally, the ordering of keys from different sources seems to be strange.
> Agent keys always come first, then the session keys. The session keys are the
> ones set explicitly, plus then the default keys. So the order is <agent,
> explicit, default>. I think this should be <explicit, agent, default>.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
