[
https://issues.apache.org/jira/browse/SSHD-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486625#comment-17486625
]
Lyor Goldstein commented on SSHD-1244:
--------------------------------------
{quote}
The SFTP feature of ProFTPD notifies 2 ^ 32-1 bytes as the initial window size
by default.
I've confirmed that SSHD can handle this without any problems, so I sent a 4GB
file to see what happens when Window Adjust is done.
{quote}
Good idea
{quote}
As a result, a Window Adjust was done and SSHD was unable to handle this
successfully.
{quote}
* How do you know that this is the reason for the failure ?
* Based on what log messages have you reached the conclusion that "a Window
Adjust was done" ?
* "SSHD was unable to handle this successfully" - I believe you that SSHD
failed, but how can you attribute it to {{SSH_MSG_CHANNEL_WINDOW_ADJUST}} with
such certainty ? Perhaps the failure is unrelated, and we might be chasing a
wrong track.
* Have you looked at the log messages ? Can you attach it and indicate where
the failure occurred and why you believe this is related to
{{SSH_MSG_CHANNEL_WINDOW_ADJUST}} ?
* How have you initialized your SSH client ? Have you used the default
configuration or added some of your own ?
There could be a myriad of reasons for the failure - without more information
about your code and log messages it is very difficult to tell what was the
reason for the failure, As I have said, it might not be
{{SSH_MSG_CHANNEL_WINDOW_ADJUST}} since as you yourself claim
{quote}
I've confirmed that SSHD can handle this without any problems
{quote}
> Client fails window adjust above INT_MAX
> ----------------------------------------
>
> Key: SSHD-1244
> URL: https://issues.apache.org/jira/browse/SSHD-1244
> Project: MINA SSHD
> Issue Type: Bug
> Affects Versions: 2.8.0
> Reporter: Ryosuke Kanda
> Assignee: Lyor Goldstein
> Priority: Minor
>
> If the new window size specified by SSH_MSG_CHANNEL_WINDOW_ADJUST exceeds
> INT_MAX, it will not be recognized correctly.
> I think the cause is in the following places:
> org.apache.sshd.common.channel.Window.expand（int）
>
> I am doing machine translation, so please allow it to be unnatural.
>
> I encountered this issue when I was using ProFTPD as an SFTP server.
> The version of ProFTPD is 1.3.5e.
> The SFTP feature of ProFTPD notifies 2 ^ 32-1 bytes as the initial window
> size by default.
> I've confirmed that SSHD can handle this without any problems, so I sent a
> 4GB file to see what happens when Window Adjust is done.
> As a result, a Window Adjust was done and SSHD was unable to handle this
> successfully.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
