tomaswolf commented on code in PR #217:
URL: https://github.com/apache/mina-sshd/pull/217#discussion_r857178945
##########
sshd-core/src/main/java/org/apache/sshd/common/channel/ChannelOutputStream.java:
##########
@@ -171,43 +227,52 @@ public synchronized void write(byte[] buf, int s, int l)
throws IOException {
"Interrupted while waiting for remote space on
write len=" + l + " to " + this)
.initCause(e);
}
- }
- session.resetIdleTimeout();
- continue;
+ session.resetIdleTimeout();
+ break;
+ default:
+ // BUFFERED implies l == 0; outer loop will terminate
+ break;
Review Comment:
Not done. I prefer to have *every* switch branch be terminated by a break,
return, or throw. (I can't remember the last time I had the urge to use a
fall-though.) It may not be necessary here, but it doesn't hurt.
##########
sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSession.java:
##########
@@ -712,6 +762,17 @@ protected boolean handleServiceRequest(String serviceName,
Buffer buffer) throws
return true;
}
+ private boolean validateServiceKexState(KexState state) {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
